Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates enforce-logical-properties to catch additional physical Tailwind utilities that have direct logical equivalents (or a logical split), closing #362.
Changes:
- Add mappings for
h-*,w-*,min-h-*,min-w-*,max-h-*,max-w-*to logicalblock/inlineequivalents. - Add a special-case mapping for
size-*that auto-fixes into two classes:block-* inline-*. - Extend tests and documentation to cover the new mappings and the multi-class
size-*fix behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/rules/enforce-logical-properties.ts |
Adds new mappings and enables returning multiple replacement classes for size-*, with updated messaging. |
src/rules/enforce-logical-properties.test.ts |
Adds coverage for the new mappings and verifies size-* is split into two logical classes (including variants / important). |
docs/rules/enforce-logical-properties.md |
Documents the newly supported physical→logical mappings, including size-* splitting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #362